Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WTF-1986] Generate types for metadata attribute properties #102

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

weirdwater
Copy link
Contributor

@weirdwater weirdwater commented Sep 3, 2024

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Compatible with: MX 🔟 (After next release of typings package)
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

To lay the groundwork for offering cross-widget filtering and sorting of data sources. Enabling widget developers to build reusable and flexible filter controls.

Relevant changes

This PR introduces the AttributeMetaDataProperty type.

What should be covered while testing?

That an attribute with the isMetaData=true flag results in a AttributeMetaData type.

@weirdwater weirdwater changed the title [WTF-1920] Generate types for metadata attribute properties [WTF-1923] Generate types for metadata attribute properties Sep 3, 2024
@weirdwater weirdwater marked this pull request as ready for review September 4, 2024 08:52
@weirdwater weirdwater requested a review from a team as a code owner September 4, 2024 08:52
@weirdwater weirdwater changed the title [WTF-1923] Generate types for metadata attribute properties [WTF-1986] Generate types for metadata attribute properties Sep 4, 2024
@weirdwater weirdwater merged commit 8b2e956 into master Sep 24, 2024
7 checks passed
@weirdwater weirdwater deleted the wtf/flexible-filtering branch September 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants